-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Dockerfile #26
base: master
Are you sure you want to change the base?
add Dockerfile #26
Conversation
The NCBI genome downloader is missing as a dependency. We installed via
Could this be added? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through the whole file again and found some things that should be adapted before merging the image. :)
# Base Image | ||
FROM ncbihackathon/ncbihackathonbase:latest | ||
|
||
# Metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The meta data should be adapted to STREAMclean I think.
cd / && \ | ||
rm -rf $DST/$FOLDER | ||
|
||
# BAMTools 2.5.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need BAMtools (if I'm not mistaken!)
make install && \ | ||
rm -rf $DST/$FOLDER $DST/$ZIP | ||
|
||
# STAR 2.5.3a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Star can be removed completely
|
||
USER biodocker | ||
|
||
RUN git clone --recursive https://github.com/NCBI-Hackathons/NanoporeMapper.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL for the repo has changed to https://github.com/NCBI-Hackathons/STREAMclean.git (the old URL works as GitHub handles redirects when repos are renamed, but would probably be nicer to have a clean setup)
mv $DST/$FOLDER/LICENSE $DST/$FOLDER/README /home/biodocker/bin/ && \ | ||
mv $DST/$FOLDER/bin/* /home/biodocker/bin/ && \ | ||
rm -rf $DST/$FOLDER | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The python modules need to be installed in order for the pipeline to run. I guess
RUN cd ~/STREAMclean & pip install -r requirements.txt
should do the trick?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.